-
Notifications
You must be signed in to change notification settings - Fork 10
Enable --days switch for getting tree list
#177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
43f9662 to
116689c
Compare
|
Hello @aliceinwire |
|
Looks like an issue with the dashboard API. |
|
thanks for this PR and finding a related bug on the dashboard api |
116689c to
5a9350d
Compare
5a9350d to
074b815
Compare
|
can you solve the branch conflict with |
074b815 to
006deb6
Compare
Resolved the conflict. |
kcidev/libs/dashboard.py
Outdated
| from kcidev.libs.common import * | ||
|
|
||
| DASHBOARD_API = "https://dashboard.kernelci.org/api/" | ||
| DASHBOARD_API = "https://dashboard.kernelci.org:9000/api/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the option interval_in_days only works when port number is specified.
Could you please explain the reason? @aliceinwire @nuclearcat
Do we have multiple instances running for dashboard APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as is using the dashboard api, could this be a dashboard problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt that adding a interval_in_days fetch parameters justify the necessity of specify the port number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the way I tested on my side without specify the port parameters and works correctly
DASHBOARD_API = "https://dashboard.kernelci.org/api/"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you mean output differs for $ kci-dev --settings ./kci-dev.toml results trees --days 1 and $ kci-dev --settings ./kci-dev.toml results trees --days 7
It doesn't in my case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you mean output differs for
$ kci-dev --settings ./kci-dev.toml results trees --days 1and$ kci-dev --settings ./kci-dev.toml results trees --days 7It doesn't in my case.
I see. That's the same result also on my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it only differs with the port number specified.
Need to ask on the dashboard repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JenySadadia thanks
|
9000 is our staging/dev instance https://staging.dashboard.kernelci.org:9000/ |
The URL is https://dashboard.kernelci.org. I think that's the production one. |
|
we should have |
006deb6 to
af9998f
Compare
|
@aliceinwire This PR is ready to be merged. Could you please approve/create a suggestion? |
For the command `kci-dev results trees`, add `--days` option to provide a period of time in days to get results for. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
af9998f to
932aa36
Compare
|
Removed port number from the dashboard API URL as the fix in the dashboard API endpoint has been deployed on production. |
For the command
kci-dev results trees, add--daysoption to provide a period of time in days toget results for.
Closes #176