maestro validate builds command fixes
#205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
force-pushed
the
fix-validate-builds-cmd
branch
3 times, most recently
from
fd258e5 to
f609207
Compare
JenySadadia
commented
Jul 11, 2025
| ) | ||
|
|
||
| for tree_branch, commits in tree_groups.items(): | ||
| # Check if any commit has issues |
Author
There was a problem hiding this comment.
The comment is not required anymore as the report will include all the build commits, including commits without any issues i.e. commits with no missing builds detected.
aliceinwire
reviewed
Jul 11, 2025
aliceinwire
reviewed
Jul 11, 2025
JenySadadia
force-pushed
the
fix-validate-builds-cmd
branch
from
f609207 to
a9e489d
Compare
JenySadadia
force-pushed
the
fix-validate-builds-cmd
branch
from
a9e489d to
5ae9e01
Compare
padovan
reviewed
Jul 11, 2025
Contributor
padovan
left a comment
padovan
left a comment
There was a problem hiding this comment.
Thanks, Jeny. The changes looks good to me and I agree in general with @aliceinwire comments.
JenySadadia
force-pushed
the
fix-validate-builds-cmd
branch
from
5ae9e01 to
5fb362f
Compare
Member
|
thanks for updating the code |
aliceinwire
reviewed
Jul 16, 2025
JenySadadia
force-pushed
the
fix-validate-builds-cmd
branch
from
5fb362f to
8197e6e
Compare
1. Fix `print_simple_list` function: - Add list of commits tested for builds history output - Add number of missing builds to the ouput 2. Add `item_type` to `print_simple_list` to make it generic for builds and boots 3. Include commits in the output for which 0 builds are detected from the dashboard 4. Implement `extract_validation_data` function for fetching validation information while generating list view report Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
JenySadadia
force-pushed
the
fix-validate-builds-cmd
branch
from
8197e6e to
59d410c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print_simple_listfunction:item_typetoprint_simple_listto make it generic for builds and boots