Skip to content

Conversation

@aliceinwire
Copy link
Member

No description provided.

@aliceinwire
Copy link
Member Author

aliceinwire commented Jan 7, 2025

I try to reproduce the problem but I don't get any error from my local environment :/

@aliceinwire
Copy link
Member Author

aliceinwire commented Jan 7, 2025

The output is like this from a Linux repository folder

$ kci-dev results --current-folder  --action=summary
git folder
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
13563da6ffcf49b8b45772e40b35f96926a7ee1e

pass/fail/inconclusive
builds: 47/0/0
boots:  592/45/6
tests:  10331/7698/851

after updating the Linux repository folder with git pull

$ kci-dev results --current-folder  --action=summary
git folder
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
fbfd64d25c7af3b8695201ebc85efe90be28c5a3

pass/fail/inconclusive
builds: 46/0/0
boots:  576/48/9
tests:  7790/6900/639

@aliceinwire
Copy link
Member Author

aliceinwire commented Jan 8, 2025

CI/CD error related: #79

@aliceinwire
Copy link
Member Author

aliceinwire commented Jan 8, 2025

CI/CD error fixed: #80

@aliceinwire
Copy link
Member Author

@padovan --current-folder option is retrieving information from the current folder repository in a similar way of what stated in the issue #64

From re reading the issue I'm starting to think that maybe just make kci-dev results without option get the current folder information instead of throwing the option missing error would be better and add a --git-folder option for specify the git repository folder

@aliceinwire
Copy link
Member Author

removed --current-folder option
now kci-dev results is giving the current folder results

@aliceinwire aliceinwire force-pushed the current-folder branch 2 times, most recently from 30db188 to 8c82728 Compare January 9, 2025 08:52
@aliceinwire
Copy link
Member Author

The new command is like this from a Linux repository folder

linux/ $ kci-dev results
git folder
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
13563da6ffcf49b8b45772e40b35f96926a7ee1e

pass/fail/inconclusive
builds: 47/0/0
boots:  592/45/6
tests:  10331/7698/851

after updating the Linux repository folder with git pull

linux/ $ kci-dev results
git folder
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
fbfd64d25c7af3b8695201ebc85efe90be28c5a3

pass/fail/inconclusive
builds: 46/0/0
boots:  576/48/9
tests:  7790/6900/639

@aliceinwire
Copy link
Member Author

aliceinwire commented Jan 10, 2025

current behavior is to:

  • check folder for .git/ folder
  • if .git folder is present go on
  • Get the .git/config file as python object
  • Get the git repository URL from the config remote "origin" url
  • Get current branch from git branch --show-current
  • Get current commit hash from .git/refs/heads/<branch-name>
    Use this information for retrieving data from the dashboard API

Copy link
Contributor

@padovan padovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arisu. This is looking quite good. I made a few suggestion that I believe will improve the quality a bit.

@padovan
Copy link
Contributor

padovan commented Jan 10, 2025

Ah, we should also update the docs to mention this new behavior.

@aliceinwire
Copy link
Member Author

aliceinwire commented Jan 10, 2025

I will update with your comments and merge this, Thanks!!!

Signed-off-by: Arisu Tachibana <arisu.tachibana@miraclelinux.com>
@aliceinwire aliceinwire merged commit 70d059c into kernelci:main Jan 15, 2025
2 checks passed
@aliceinwire aliceinwire added this to the v0.1.2 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants