Skip to content

Some code confused me. #1

@run1999

Description

@run1999

Please check your code.

domains/s2orc/extract_papers.py

8 from joblib import Parallel, delayed
Does this Parallel module work in your code?

29 if len(papers) > 512:
I think it should be ‘==’ but not ‘>‘ , cause your shell script batch size is 512 , but your code create 513 files instead.

52 return metadata
Is this 'metadata' declared in the function?

By the way, I don't see your "get_metadata" used in the main function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions