Conversation
…of messages we read in the readFile. Also, reserve the last 4 bytes at the end of the file for the number of messages in that file.
…ile now contains readMessages and writeMessages.
…omplete file and completely reading a file.
…writeMessages and readMessages in skipToNextRWFile.
…or disk space limit.
…t that these numbers are accurate.
leonzz
reviewed
Jun 1, 2021
leonzz
approved these changes
Jun 2, 2021
courageJ
reviewed
Jun 2, 2021
courageJ
reviewed
Jun 2, 2021
courageJ
approved these changes
Jun 3, 2021
Collaborator
CatherineF-dev
left a comment
There was a problem hiding this comment.
Do we need to update writeMessages and readMessages in handleReadError now?
Owner
Author
Yes!!!! Nice catch! |
CatherineF-dev
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation
Testing
Next Steps
Note
This pr will only handle the tracking of writeMessages and readMessages. The implementation of making space when we surpass the diskSizeLimit will come later.