bugfix: Fixed issue with global shared RegExps for queue#10
Merged
Conversation
moredure
changed the title
Collaborator
|
Thanks @moredure for sending in the fix. Could you update the description and describe the issue in more detail? IIUC shared global var should be ok as Golang regexp is documented as safe for concurrent use: https://pkg.go.dev/regexp#Regexp |
Author
|
@leonzz, updated description |
moredure
changed the title
leonzz
approved these changes
Sep 26, 2023
Collaborator
|
/lgtm |
Collaborator
|
cc @leonzz I think we can mark the conversation as resolved and let it merged? |
Collaborator
|
Thanks! resolved the comment thread and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple instances of queue instantiated shared regexp can result in incorrect regexp used for all except last instance of queue created.