Log shim panic logs before shim cleanup#16
Conversation
|
@ambarve Bundle cleanup always gets called when cleaning up a container but shim delete doesn't, is that correct? So in most cases we'd get the shim panic logs logged twice? Once on shim delete and once on bundle cleanup when reading the file itself? |
|
@dcantah You are right, I was planning on removing that code from the shim delete command, I will push a PR for that. |
|
@ambarve Cool thanks for clarification! |
|
@dcantah Actually we shouldn't remove the logging changes added to hcsshim. This is because in some cases containerd calls shim delete first before calling delete on the bundle. In that case the shim delete command will remove the bundle directory and bundle cleanup will never find panic.log file. |
|
@ambarve Cool thanks for checking on this |
ambarve
force-pushed
the
shim_panic_log
branch
2 times, most recently
from
aec59f7 to
3b7de65
Compare
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
Small question and nit. Otherwise, LGTM.
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Same comment here about errors.Is but otherwise lgtm!
We already have code in hcsshim that logs the contents of the panic.log file during shim delete command. However, that doesn't handle all of the cases. This change should fix that. Signed-off-by: Amit Barve <ambarve@microsoft.com>
4 participants
Changes the bundle cleanup function to look for a file named panic.log and log the contents of that file if it exists.
We already added a change to hcsshim to log the contents of panic.log file during
shim deletecommand. However, that doesn't handle all of the cases. This change should fix that.Signed-off-by: Amit Barve ambarve@microsoft.com