Backport Unify snapshotters and separate scratch and image layers change#30
Merged
ambarve merged 1 commit intokevpar:fork/release/1.4from Jan 25, 2022
Merged
Conversation
…ifferent directory (containerd#27) * Refactor windows snapshotters Both LCOW & WCOW snapshotters have many functions that are identical and some other functions have common code. This change refactors those snapshotters to remove duplicate code. This refactor will also help when adding other features like storing scratch snapshots in a different location. * Support to override scratch snapshot location Some containers do heavy IO to the scratch, in case of LCOW/WCOW the scratch itself is a VHD that is stored on the same disk as that of other snapshots (including the image layers). If containerd is pulling multiple images and one or more containers are doing heavy IO to the scratch at the same time, that causes disk contention and related issues. This change allows the user to set a config (either in containerd.toml or in the container configuration) that specifies another directory inside which the scratch of all containers (or that specific container) should be stored. Signed-off-by: Amit Barve <ambarve@microsoft.com> (cherry picked from commit 333a72b) Signed-off-by: Amit Barve <ambarve@microsoft.com>
Collaborator
Author
anmaxvl
approved these changes
Dec 9, 2021
dcantah
approved these changes
Jan 8, 2022
Collaborator
|
@ambarve what's the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both LCOW & WCOW snapshotters have many functions that are identical and some other
functions have common code. This change refactors those snapshotters to remove duplicate
code.
This refactor will also help when adding other features like storing scratch snapshots in a
different location.
Some containers do heavy IO to the scratch, in case of LCOW/WCOW the scratch itself is a
VHD that is stored on the same disk as that of other snapshots (including the image
layers). If containerd is pulling multiple images and one or more containers are doing
heavy IO to the scratch at the same time, that causes disk contention and related
issues. This change allows the user to set a config (either in containerd.toml or in the
container configuration) that specifies another directory inside which the scratch of all
containers (or that specific container) should be stored.
Signed-off-by: Amit Barve ambarve@microsoft.com
(cherry picked from commit 333a72b)
Signed-off-by: Amit Barve ambarve@microsoft.com