Skip to content

feat: support Angular 20#31

Closed
lekhmanrus wants to merge 1 commit intokeycloakify:mainfrom
lekhmanrus:feat/angular-20
Closed

feat: support Angular 20#31
lekhmanrus wants to merge 1 commit intokeycloakify:mainfrom
lekhmanrus:feat/angular-20

Conversation

@lekhmanrus
Copy link
Copy Markdown
Contributor

@lekhmanrus lekhmanrus commented Jun 4, 2025

Summary by CodeRabbit

  • Chores

    • Upgraded Angular and various development dependencies to their latest compatible versions.
    • Updated package manager specification to Yarn 4.6.0.
  • Style

    • Removed unnecessary trailing whitespace from a template literal string.
  • Refactor

    • Updated imports for the DOCUMENT token to use a consistent source within Angular packages.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 4, 2025

Walkthrough

This update upgrades Angular and related development dependencies to version 20.0.0 in the package.json, and adjusts the import source of the DOCUMENT token in two provider files to use @angular/core instead of @angular/common. Additionally, a minor whitespace cleanup is made in a service file.

Changes

Files Change Summary
package.json Upgraded Angular and related devDependencies to 20.0.0; updated several other devDependencies.
src/account/providers/keycloakify-angular/keycloakify-angular.providers.ts
src/login/providers/keycloakify-angular/keycloakify-angular.providers.ts
Changed DOCUMENT import source from @angular/common to @angular/core.
src/login/services/login-resource-injector/login-resource-injector.service.ts Removed trailing whitespace from a template literal string.

Poem

Hopping through the code with glee,
Angular twenty shines for me!
Imports tidied, whitespace gone,
Dependencies now marching on.
With every hop, the code feels bright—
Upgrades and tweaks done just right!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/login/services/login-resource-injector/login-resource-injector.service.ts (1)

65-66: Trim whitespace in template literal
A blank line was removed inside the multi-line string. For cleaner output, consider normalizing indentation or applying .trim() on the template to avoid unintended leading/trailing whitespace.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2a19d7 and 07ff8f6.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • package.json (2 hunks)
  • src/account/providers/keycloakify-angular/keycloakify-angular.providers.ts (1 hunks)
  • src/login/providers/keycloakify-angular/keycloakify-angular.providers.ts (1 hunks)
  • src/login/services/login-resource-injector/login-resource-injector.service.ts (1 hunks)
🔇 Additional comments (5)
package.json (3)

6-6: Verify Yarn 4 packageManager configuration
You added "packageManager": "yarn@4.6.0". Ensure the repo is fully configured for Yarn 4 (e.g. .yarnrc.yml, templates under .yarn/releases) and update lockfiles (e.g. yarn.lock) accordingly to prevent install mismatches.


40-46: Upgrade Angular devDependencies to 20.0.0
The core Angular packages (@angular/cli, @angular/core, etc.) have been bumped to 20.0.0. Please confirm compatibility with any peer dependencies (including ng-packagr) and update your peerDependencies ranges or project configs if needed.


48-48: Validate other tooling and linting upgrades
Multiple devDependencies (ESLint, Angular-ESLint, Keycloakify, zod, etc.) were updated. Run your full lint/build/test pipeline to ensure no breaking changes, and review any updated rule configs or plugin APIs.

Also applies to: 50-50, 56-56, 58-58, 61-63, 70-71

src/login/providers/keycloakify-angular/keycloakify-angular.providers.ts (1)

5-7: Standardize DOCUMENT import from @angular/core
You’ve moved DOCUMENT (and provideAppInitializer) into the @angular/core import to align with Angular 20. Ensure no leftover imports from @angular/common remain and that this matches the account provider.

src/account/providers/keycloakify-angular/keycloakify-angular.providers.ts (1)

5-7: Align DOCUMENT and provideAppInitializer imports
Updated imports to pull DOCUMENT and provideAppInitializer from @angular/core, mirroring the login provider. This is consistent with Angular 20 conventions.

@luca-peruzzo
Copy link
Copy Markdown
Member

@lekhmanrus Hi, thanks for your PR!
We would like to keep the version of yarn at v1, at the moment we are not willing to update it.
So you could create a new PR (or edit this) with only the style fix as soon as we merge #32 .
Thanks for your work, we really appreciate it!

@kathari00
Copy link
Copy Markdown
Collaborator

Hello I merged #32. If you like you can still update the styles.

@kathari00 kathari00 closed this Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants