-
Notifications
You must be signed in to change notification settings - Fork 72
Add UEFI log handler, use it to send UEFI count #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UEFI log handler, use it to send UEFI count #1022
Conversation
c66ad32 to
502dc4f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
502dc4f to
c69a77b
Compare
|
/packit retest-failed |
c69a77b to
52128d5
Compare
174851f to
31954d6
Compare
20ca76a to
685ec5e
Compare
685ec5e to
2ed4132
Compare
ansasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to replace the sha2 usage with the openssl implementation
5c18155 to
31361ee
Compare
Resolves: keylime#1020 Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
31361ee to
764edd7
Compare
ansasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes
| Self::from_bytes(&log_bytes) | ||
| } | ||
|
|
||
| pub fn from_bytes(log_bytes: &[u8]) -> Result<Self> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is OK for now to parse in such ad-hoc way, but in future we should probably write a pest grammar to parse the UEFI log (and same for the IMA logs).
Resolves: #1020