Skip to content

Conversation

@sarroutbi
Copy link
Contributor

Resolves: #1020

@keylime-bot keylime-bot added bug Something isn't working Push Model Issues that are specific to the Keylime Push Model new binary labels Jun 9, 2025
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch 19 times, most recently from c66ad32 to 502dc4f Compare June 9, 2025 17:00
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 88.51351% with 17 lines in your changes missing coverage. Please review.

Project coverage is 62.71%. Comparing base (2a633dc) to head (764edd7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/config/push_model.rs 38.46% 8 Missing ⚠️
keylime-push-model-agent/src/struct_filler.rs 61.53% 5 Missing ⚠️
keylime/src/uefi/uefi_log_handler.rs 96.66% 4 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 62.71% <88.51%> (+0.54%) ⬆️
upstream-unit-tests 62.71% <88.51%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/cert.rs 92.10% <ø> (ø)
keylime/src/error.rs 7.64% <100.00%> (+0.44%) ⬆️
keylime/src/uefi/uefi_log_handler.rs 96.66% <96.66%> (ø)
keylime-push-model-agent/src/struct_filler.rs 83.33% <61.53%> (-3.19%) ⬇️
keylime/src/config/push_model.rs 45.05% <38.46%> (+1.03%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from 502dc4f to c69a77b Compare June 9, 2025 18:11
@sarroutbi sarroutbi marked this pull request as ready for review June 9, 2025 18:11
@sarroutbi
Copy link
Contributor Author

/packit retest-failed

@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from c69a77b to 52128d5 Compare June 10, 2025 13:55
@sarroutbi sarroutbi removed the request for review from sergio-correia June 11, 2025 14:03
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch 2 times, most recently from 174851f to 31954d6 Compare June 11, 2025 14:21
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch 5 times, most recently from 20ca76a to 685ec5e Compare June 11, 2025 15:18
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from 685ec5e to 2ed4132 Compare June 12, 2025 08:36
Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace the sha2 usage with the openssl implementation

@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch 2 times, most recently from 5c18155 to 31361ee Compare June 16, 2025 12:53
@sarroutbi sarroutbi requested a review from ansasaki June 16, 2025 12:53
Resolves: keylime#1020

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from 31361ee to 764edd7 Compare June 16, 2025 13:08
Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes

Self::from_bytes(&log_bytes)
}

pub fn from_bytes(log_bytes: &[u8]) -> Result<Self> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK for now to parse in such ad-hoc way, but in future we should probably write a pest grammar to parse the UEFI log (and same for the IMA logs).

@ansasaki ansasaki merged commit 3af2075 into keylime:master Jun 16, 2025
12 checks passed
@sarroutbi sarroutbi deleted the 202506091610-add-uefi-log-handler branch June 17, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Push Model Issues that are specific to the Keylime Push Model new binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push Model agent is not sending amout of UEFI logs amount appropriately

4 participants