Skip to content

Conversation

@sarroutbi
Copy link
Contributor

No description provided.

@sarroutbi sarroutbi force-pushed the 202506121143-add-ima-log-parser branch 7 times, most recently from b762b67 to d3bb8b6 Compare June 12, 2025 10:42
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.12%. Comparing base (4f0360d) to head (9c05180).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/ima/ima_log.rs 71.42% 4 Missing ⚠️
keylime-push-model-agent/src/struct_filler.rs 57.14% 3 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 62.12% <66.66%> (-0.01%) ⬇️
upstream-unit-tests 62.12% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/structures/capabilities_negotiation.rs 71.42% <ø> (ø)
keylime-push-model-agent/src/struct_filler.rs 86.51% <57.14%> (-2.51%) ⬇️
keylime/src/ima/ima_log.rs 71.42% <71.42%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi sarroutbi marked this pull request as ready for review June 12, 2025 11:55
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202506121143-add-ima-log-parser branch from d3bb8b6 to d691907 Compare June 12, 2025 14:15
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi changed the title Add IMA log parser Push Model: Add IMA log parser to send correct entry count Jun 12, 2025
@sarroutbi sarroutbi added Push Model Issues that are specific to the Keylime Push Model new binary labels Jun 12, 2025
@sarroutbi sarroutbi added the bug Something isn't working label Jun 13, 2025
Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki ansasaki merged commit 2a633dc into keylime:master Jun 16, 2025
19 checks passed
@sarroutbi sarroutbi deleted the 202506121143-add-ima-log-parser branch June 16, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Push Model Issues that are specific to the Keylime Push Model new binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants