Fix race conditions in tests #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The payload tests that set the environment variable `KEYLIME_TEST_DIR` could affect each other. This adds a mutex to make these tests to not run concurrently. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
The tests could enter in a race condition where one test removes the file while the other is using it. This was caused by the files using the same path. This uses a temporary directory for each test. This makes it unnecessary to manually remove the files and also avoids the risk of race conditions since each temporary directory has a unique name. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests could fail due to race conditions:
keylime-agent/src/payloads.rs, thetest_run_encrypted_payload()andtest_payload_worker()could affect each other because both set the environment variableKEYLIME_TEST_DIRkeylime/src/cert.rs, thetest_cert_no_server_cert()andtest_server_from_server_key()could delete each other's files because they used the same path