Skip to content

main: Use more descriptive message for missing files error #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ansasaki merged 1 commit into from
Jun 28, 2022
Merged

main: Use more descriptive message for missing files error #416

ansasaki merged 1 commit into from
Jun 28, 2022

Conversation

@ansasaki
Copy link
Contributor

@ansasaki ansasaki commented Jun 28, 2022

Use more descriptive message when required paths are missing instead of
the generic message.

Signed-off-by: Anderson Toshiyuki Sasaki ansasaki@redhat.com

@ashcrow
Copy link
Contributor

ashcrow commented Jun 28, 2022

Fedora tests failed on the following in a few places:

error: using Result.or_else(|x| Err(y)), which is more succinctly expressed as map_err(|x| y)

@ansasaki
Copy link
Contributor Author

ansasaki commented Jun 28, 2022

Fedora tests failed on the following in a few places:

error: using Result.or_else(|x| Err(y)), which is more succinctly expressed as map_err(|x| y)

I'll replace the implementation. I forgot to run cargo clippy for this.

@ansasaki
main: Use more descriptive message for missing files error
e20b936 
Use more descriptive message when required paths are missing instead of
the generic message.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
ashcrow
ashcrow approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki ansasaki merged commit ad8608f into keylime:master Jun 28, 2022
@ansasaki ansasaki deleted the error_messages branch June 28, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow ashcrow approved these changes

@puiterwijk puiterwijk Awaiting requested review from puiterwijk

@lkatalin lkatalin Awaiting requested review from lkatalin

Assignees

@ashcrow ashcrow

@puiterwijk puiterwijk

@lkatalin lkatalin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ansasaki @ashcrow @puiterwijk @lkatalin