keys_handler: Use scopes to drop mutexes before await #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MutexGuard is not async aware, meaning the mutexes should be unlocked before any await call. This change uses scopes to drop the locked mutexes before calling await. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Contributor
|
Interesting - how was this working before, without the scopes? Was it just keeping the mutex locked indefinitely? |
Contributor
Author
|
/packit retest-failed |
Contributor
Author
Probably we were lucky and nobody tried to get the mutex while we were awaiting (meaning only one request were being handled at once) |
lkatalin
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MutexGuard is not async aware, meaning the mutexes should be
unlocked before any await call. This change uses scopes to drop the
locked mutexes before calling await.
Signed-off-by: Anderson Toshiyuki Sasaki ansasaki@redhat.com