tpm: Respect ek_handle from config #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/ek-config
branch
from
485c792 to
d74d80d
Compare
Contributor
|
Test log says: |
ueno
force-pushed
the
wip/dueno/ek-config
branch
2 times, most recently
from
f6b0fe8 to
0bbf0b0
Compare
ueno
force-pushed
the
wip/dueno/ek-config
branch
2 times, most recently
from
0f76785 to
af5e64d
Compare
ueno
force-pushed
the
wip/dueno/ek-config
branch
from
af5e64d to
0fac890
Compare
Contributor
|
@ueno I see some TPM password and owner auth related code - we're not trying to take ownership of the TPM here, right? |
ueno
force-pushed
the
wip/dueno/ek-config
branch
2 times, most recently
from
149a209 to
fbd3a62
Compare
Contributor
Author
Contributor
|
Thanks @ueno. The password seems okay to access the EK as long as the agent doesn't take ownership of the TPM. |
This adds support for the "ek_handle" option in the cloud_agent configuration, which previously was not checked and a new EK was always generated. This also adds partial support for "tpm_ownerpassword" for the use with "ek_handle". Signed-off-by: Daiki Ueno <dueno@redhat.com>
ansasaki
force-pushed
the
wip/dueno/ek-config
branch
from
fbd3a62 to
badaf2b
Compare
Contributor
kkaarreell
added a commit
to kkaarreell/rust-keylime
that referenced
this pull request
Jul 26, 2022
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <ksrot@redhat.com>
kkaarreell
added a commit
to kkaarreell/rust-keylime
that referenced
this pull request
Jul 26, 2022
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <ksrot@redhat.com>
kkaarreell
added a commit
to kkaarreell/rust-keylime
that referenced
this pull request
Jul 26, 2022
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <ksrot@redhat.com>
Contributor
|
@kkaarreell I opened #433 |
kkaarreell
added a commit
to kkaarreell/rust-keylime
that referenced
this pull request
Sep 16, 2022
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <ksrot@redhat.com>
lkatalin
pushed a commit
that referenced
this pull request
Sep 16, 2022
The option has been introduced in #426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <ksrot@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it always generated new EK handle even if the "ek_handle"
option is set to use the existing key.
Signed-off-by: Daiki Ueno dueno@redhat.com