Skip to content

Conversation

@kkaarreell
Copy link
Contributor

These context are to be used for proper test case filtering.
Current upstream plan installs modified Rust agent which
reads faked measured boot log, enabling measured boot testing
on systems with runtime swtpm emulation.
Distribution RPMs are not modified this way and undefined context
faked_measured_boot_log gives as a way how to avoid running measured
boot test that would fail.

Signed-off-by: Karel Srot ksrot@redhat.com

These context are to be used for proper test case filtering.
Current upstream plan installs modified Rust agent which
reads faked measured boot log, enabling measured boot testing
on systems with runtime swtpm emulation.
Distribution RPMs are not modified this way and undefined context
faked_measured_boot_log gives as a way how to avoid running measured
boot test that would fail.

Signed-off-by: Karel Srot <ksrot@redhat.com>
@kkaarreell
Copy link
Contributor Author

Rust / Fedora tests failure should not be related to this commit. Can anyone please take a look if this is a know issue? Thank you.

@lkatalin
Copy link
Contributor

lkatalin commented Sep 1, 2022

Rust / Fedora tests failure should not be related to this commit. Can anyone please take a look if this is a know issue? Thank you.

#443 should help

@kkaarreell
Copy link
Contributor Author

Hello @ueno @lkatalin @lukehinds , could you please merge this PR? It only sets test metadata and CI failure is clearly unrelated. We need improved test filtering for ongoing RHEL testing. That being said, I will merge RedHat-SP-Security/keylime-tests#193 either way, but not having PR#442 merged would mean that functional/measured-boot-swtpm-sanity test won't be run for the Rust agent in upstream Packit CI.

@lukehinds
Copy link
Member

lukehinds commented Sep 5, 2022

I honestly don't know enough about packit to review, is this for downstream testing? if so, I can merge it as it's not going to have any impact here?

@lkatalin
Copy link
Contributor

lkatalin commented Sep 7, 2022

I'm fine merging after it's rebased on #443 (which still needs to be merged)

@lkatalin
Copy link
Contributor

lkatalin commented Sep 7, 2022

I'm fine merging after it's rebased on #443 (which still needs to be merged)

@kkaarreell I just merged #443 . If you are okay rebasing, I can merge this one asap.

@lkatalin
Copy link
Contributor

lkatalin commented Sep 7, 2022

I'm fine merging after it's rebased on #443 (which still needs to be merged)

@kkaarreell I just merged #443 . If you are okay rebasing, I can merge this one asap.

Actually, maybe it will just let me bring in the changes through here.

@lkatalin lkatalin merged commit f0c9ca6 into keylime:master Sep 7, 2022
@kkaarreell kkaarreell deleted the context_agent branch September 7, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants