main: only read uuid from KeylimeConfig #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
reviewed
Dec 8, 2022
THS-on
force-pushed
the
bug/hash_ek_uuid
branch
from
e37997e to
350efed
Compare
aplanas
approved these changes
Dec 8, 2022
Contributor
|
I have tried to implement reproducer for this issue in keylime-tests but my test scenario is failing even with this fix. |
Member
Author
|
The issue was with the reproducer and not the fix, if I see that correctly. |
Contributor
Yes, false alarm. I am sorry for that |
The main function also had a local variable called uuid. This variable contained either the provided uuid or when "hash_ek" was set the sha256 hash of the EK. We never updated the KeylimeConfig struct which caused a mismatch between uuids used in the program. Instead we now mutate the KeylimeConfig when "hash_ek" is set to the correct value. Signed-off-by: Thore Sommer <mail@thson.de>
ansasaki
force-pushed
the
bug/hash_ek_uuid
branch
from
350efed to
8d4ee27
Compare
ansasaki
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main function also had a local variable called uuid. This variable
contained either the provided uuid or when "hash_ek" was set the sha256 hash
of the EK. We never updated the KeylimeConfig struct which caused a mismatch
between uuids used in the program. Instead we now mutate the KeylimeConfig
when "hash_ek" is set to the correct value.