Remove unused option "openstack" for obtaining uuid #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koncpa
force-pushed
the
remove_uuid_openstack
branch
from
04fbca2 to
8f0c982
Compare
aplanas
approved these changes
Jan 12, 2023
Contributor
|
@Koncpa the change LGTM, but maybe you can retry the --signof? The email seems has the separator missings;
I would expect:
Maybe this is why the DCO test complains |
Koncpa
force-pushed
the
remove_uuid_openstack
branch
from
8f0c982 to
ea0fad7
Compare
ansasaki
force-pushed
the
remove_uuid_openstack
branch
from
ea0fad7 to
2428265
Compare
THS-on
approved these changes
Feb 7, 2023
ansasaki
force-pushed
the
remove_uuid_openstack
branch
from
2428265 to
97bdb73
Compare
For python agent was openstack option already removed, and in rust agent is stil placeholder for this option, but won't be used. [1] Remove related unit test and notes about openstack method in agent conf. Can be confusing for user to see openstack option as method for obtaining uuid. [1] keylime/keylime@c9f7906 Signed-off-by: Patrik Koncity <pkoncity@redhat.com>
ansasaki
force-pushed
the
remove_uuid_openstack
branch
from
97bdb73 to
113f4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python agent was openstack option already removed, and in rust agent is stil placeholder for this option, but won't be used. [1] Remove related unit test and notes about openstack method in agent conf. Can be confusing for user to see openstack option as method for obtaining uuid.
[1] keylime/keylime@c9f7906
Signed-off-by: Patrik Koncity pkoncity@redhat.com