Allow setting binary measured boot log path on RPM binaries

[ansasaki]

Allow setting the path to the binary bios measurements log file via the TPM_BINARY_MEASUREMENTS environment variable when build with the testing feature enabled.

The binaries in the RPM are build with the testing feature enabled.

Fixes #490

[codecov]

Codecov Report

Merging #554 (cd9c214) into master (bf33c9a) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head cd9c214 differs from pull request most recent head 2e9a322. Consider uploading reports for the commit 2e9a322 to get more accurate results

Additional details and impacted files

Flag	Coverage Δ
e2e-testsuite	58.72% <ø> (ø)
upstream-unit-tests	58.89% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
keylime-agent/src/common.rs	70.18% <ø> (ø)
keylime-agent/src/main.rs	35.38% <50.00%> (+0.33%)	⬆️

[aplanas]

I am a bit concern that this rpm/ can confuse later. It is to generate RPMs for the testing farm, and somehow unrelated with the project.

IMHO all this RPM code should be living in the test side and not in the project side, as in any case the testing farm is not really testing the released fedora nor centos package.

If this is not possible, at least we should add a README under rpm/ to clarify that "If you are looking for the reference spec file, do not look here"

[ansasaki]

I am a bit concern that this rpm/ can confuse later. It is to generate RPMs for the testing farm, and somehow unrelated with the project.

IMHO all this RPM code should be living in the test side and not in the project side, as in any case the testing farm is not really testing the released fedora nor centos package.

If this is not possible, at least we should add a README under rpm/ to clarify that "If you are looking for the reference spec file, do not look here"

I agree that it may be confusing at the moment, but the goal in future is to maintain the specfile here and automate downstream maintenance as well, so it will become the "reference specfile".

For now, the rpms will be used to avoid recompiling the agent for testing both in this repo, as well as in keylime/keylime. It makes easier for testing farm to have the rpm packages in Copr.

I'll add a commit to explain this in README.

[aplanas]

Seems that the Centos package fails for some GPG key. Not sure why, but the changes LGTM

[ansasaki]

I added a small change to make the RPMS more usable: packit was picking the version from the tag (v0.2.0), which made RPM to not consider it an update because keylime-0.1.0 > keylime-v0.2.0 (note the v prepending the version number). I had to manually change the version to result in keylime-0.2.0 for the RPM.

I'll drop the temporary commit and push the changes.