Remove private_in_public #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
the change lgtm after checking the documentation. Maybe is OK to remove the draft flag? |
Contributor
Author
Hello. I will remove the draft flag. The issue happening on fedora-37 tests is not related to this PR, so I am good with it. Thanks @aplanas |
Contributor
|
/packit retest-failed |
ansasaki
approved these changes
Sep 22, 2023
Resolves: keylime#652 According to The Rust RFC Book type privacy chapter: https://rust-lang.github.io/rfcs/2145-type-privacy.html "private_in_public" compatibility lint will be removed and its uses will be reported as warnings by "renamed_and_removed_lints" Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
ansasaki
force-pushed
the
202309191312_remove_private_in_public
branch
from
88d239d to
931042a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #652
According to The Rust RFC Book type privacy chapter: https://rust-lang.github.io/rfcs/2145-type-privacy.html "private_in_public" compatibility lint will be removed and its uses will be reported as warnings by
"renamed_and_removed_lints"