-
Notifications
You must be signed in to change notification settings - Fork 72
Add the ability to use persistent handles for IDevID and IAK rather than regenerating, and add auth values for them #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to use persistent handles for IDevID and IAK rather than regenerating, and add auth values for them #785
Conversation
|
/packit retest-failed |
d1372d0 to
a0035d8
Compare
keylime/src/tpm.rs
Outdated
| /// | ||
| /// # Return | ||
| /// The corresponding KeyHandle, or a TPMError | ||
| pub fn get_key_handle( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you declared this method as public, but it is currently only used to get the handles for IDevID and IAK keys.
Do you see future usage of this in other use case? If not, could you make it private by removing the pub keyword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it could be a useful method but did not have a specific use-case in mind. I'll change to private and we can always change back to public if we want to use it in future.
| # Alternatively if the keys are persisted, provide the handles for their location below, and optionally their passwords. | ||
| # If handles are provided, they will take priority over templates/algorithms selected above. | ||
| # To use a hex password, use the prefix "hex:" at the start of the password. | ||
| idevid_password = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are adding new configuration options, do not forget to make a PR to add the configuration files to the configuration upgrade template.
I'll create an issue when we merge this to remind you.
|
@Isaac-Matthews Could you please rebase on top of current master? |
Signed-off-by: Isaac-Matthews <isaac.matthews@hpe.com>
a0035d8 to
cefe87e
Compare
Signed-off-by: Isaac-Matthews <isaac.matthews@hpe.com>
cefe87e to
562641c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ansasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
I created RedHat-SP-Security/keylime-tests#587 to track the end-to-end test creation
This PR adds into the config the ability to specify handles and auth values for IDevID and IAK keys. The auth values function in the same way as the TPM ownerpassword in that they can be hex values.
The new config options are: