Skip to content

Conversation

@sarroutbi
Copy link
Contributor

Related: #932

@sarroutbi sarroutbi force-pushed the 20250404-add-evidence-handling-structure branch 7 times, most recently from 3b23269 to acaf1f6 Compare April 4, 2025 10:53
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (1621e73) to head (39b15a1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/structures/evidence_handling.rs 82.53% 11 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 63.90% <82.53%> (+0.16%) ⬆️
upstream-unit-tests 63.90% <82.53%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/structures/evidence_handling.rs 82.53% <82.53%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi sarroutbi force-pushed the 20250404-add-evidence-handling-structure branch 11 times, most recently from 1590884 to e1e6d32 Compare April 10, 2025 16:04
@sarroutbi sarroutbi changed the title [DRAFT, DONOTMERGE]: Define EvidenceHandling structures [DONOTMERGE]: Define EvidenceHandling structures Apr 10, 2025
@sarroutbi sarroutbi force-pushed the 20250404-add-evidence-handling-structure branch 5 times, most recently from 2cf58e5 to 8e8538f Compare April 11, 2025 15:33
@sarroutbi sarroutbi force-pushed the 20250404-add-evidence-handling-structure branch 2 times, most recently from cf23eb8 to de6f7d4 Compare April 28, 2025 10:29
@sarroutbi sarroutbi changed the title [DONOTMERGE]: Define EvidenceHandling structures Define EvidenceHandling structures Apr 28, 2025
@sarroutbi sarroutbi marked this pull request as ready for review April 28, 2025 10:29
@sarroutbi sarroutbi requested a review from stringlytyped April 28, 2025 10:30

// For ImaLog/UefiLog differentiation, entry_count must be checked
impl TryFrom<JsonValue> for EvidenceData {
type Error = String;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK for now using a String as the error type, but in future it would be better to have the specific error types defined for evidence handling.

Related: keylime#932

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 20250404-add-evidence-handling-structure branch from de6f7d4 to 39b15a1 Compare May 5, 2025 15:59
@sarroutbi sarroutbi merged commit c19a1ac into keylime:master May 6, 2025
13 checks passed
@sarroutbi sarroutbi deleted the 20250404-add-evidence-handling-structure branch May 6, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants