Move SymmKey from common to the keylime library #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
force-pushed
the
move_symmkey
branch
2 times, most recently
from
f7f6d68 to
a82d7dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sarroutbi
approved these changes
Apr 10, 2025
Contributor
sarroutbi
left a comment
sarroutbi
left a comment
There was a problem hiding this comment.
I really like this kind of code refactor, due to two main reasons:
1 - It isolates and modularizes code outside agent
2 - It provides a complete coverage of the refactor code
Changes LGTM
sergio-correia
approved these changes
Apr 10, 2025
Contributor
sergio-correia
left a comment
sergio-correia
left a comment
There was a problem hiding this comment.
Thanks, looks good to me.
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Move the code for the shared type SymmKey out of the common.rs file into the keylime library. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the SymmKey structure from
common.rsinto the keylime library (crypto::symmkey).This is to continue the effort to move the code that can be shared from the
keylime-agentapplication to thekeylimelibrary