FromExecutingAssembly and FromCallingAssembly are misleading #92

[savornicesei]

Got bitten today by this so this would help others, with no impact on functionality.

[khellang]

Hey @savornicesei! 👋🏻

Thanks for the PR! 😄

Can we just obsolete both? FromAssemblies(Assembly.GetCallingAssembly()) isn't really much more typing and avoids the confusion altogether.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a634e58) 64.71% compared to head (9767e31) 62.75%.
Report is 20 commits behind head on feature/net8.0.

❗ Current head 9767e31 differs from pull request most recent head d0fdbdb. Consider uploading reports for the commit d0fdbdb to get more accurate results

Additional details and impacted files

@@                Coverage Diff                 @@
##           feature/net8.0     #222      +/-   ##
==================================================
- Coverage           64.71%   62.75%   -1.96%     
==================================================
  Files                  25       25              
  Lines                1278     1278              
  Branches                0      102     +102     
==================================================
- Hits                  827      802      -25     
  Misses                451      451              
- Partials                0       25      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[savornicesei]

@khellang Done

[khellang]

Thanks! 😄 I'll set aside some time this weekend or next week to try to get the .NET 8 version out the door.