Fix AddClasses method to take only public classes not private#238
Fix AddClasses method to take only public classes not private#238khellang merged 1 commit intokhellang:masterfrom
Conversation
|
Hmm. It's really unfortunate that the different overloads have different behaviors. No clue how it ended up that way. But this is a pretty big breaking change, as code that previously resolved fine, would now start throwing. I need to consider this for a bit 😅 |
|
Let's see how it works out 😅 Thanks @AntonyNET! |
|
Ouch. Quite a breaking one. |
|
Should have been a change to the documentation to match code rather than the code changing to match documentation. This is a very large breaking change that got included on a minor release. |
|
Yeah, if it turns out this will break a lot of people, we might want to release it as a major version instead |
It's VERY fast to fix; just pass |
|
It is very fast to fix indeed, but broke everything on our side unfortunately (before we figure out the root cause). And fully agree with: |
|
See #244 |
Documentation of method IImplementationTypeSelector.AddClasses(Action action) says that "Adds all public, non-abstract classes from the selected assemblies that" but in implementation this method takes private classes too:
AddClasses(action, publicOnly: false).
Sync code with documentation.