ActivatorUtilities.CreateFactory created breaking change from version 4.2.2 to 5.0.1#239
Merged
khellang merged 1 commit intokhellang:masterfrom Dec 23, 2024
Merged
Conversation
Owner
|
Thank you @mesies! 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created to solve #235, on the premise that upgrade from 4.2.2 to 5.0.1 should have no breaking changes,
The reason for the issue is that for example Decorator3 does not request IDecoratedService but requests a concrete class that implements IDecoratedService.
This behavior is supported by ActivatorUtilities.CreateInstance since it uses the IServiceProvider to inject constructor arguments,
but ActivatorUtilities.CreateFactory expects the contructor to have IDecoratedService, which is not the case in this example.
Thanks for all the hard work!
Let me know what you think