Avoid scanning of entire repo when a file is deleted#1
Merged
khhipparagi merged 1 commit intoDec 15, 2023
Merged
Conversation
Owner
Author
|
Merging awslabs#247 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The git secrets scans the entire repo when file is removed. For large repos, this impacts the user experience, if they are using any IDE for development, developer need to use terminal to force git secrets to skip the scan with
--no-verifyoption.Description of changes:
This change is done, when no files are returned, then
pre_commit_hookwill gracefully return instead of callingscan_with_fn_or_diefunction.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.