Open
Conversation
Member
elgertam
commented
Jun 18, 2019
elgertam
commented
- Added exception when a character in the path is not valid on Synapse
- Added test verifying that invalid paths throw exceptions
* Added exception when a character in the path is not valid on Synapse * Added test verifying that invalid paths throw exceptions
pcstout
requested changes
Jun 24, 2019
Member
pcstout
left a comment
pcstout
left a comment
There was a problem hiding this comment.
Maybe we can catch the filename errors (on .store()) and pretty them up that way we don't have to keep a list of valid/invalid chars.
| syn_entity = None | ||
|
|
||
| # check for valid characters in string | ||
| for rel_part in sys_path.rel_parts: |
Member
There was a problem hiding this comment.
This probably needs to be a method so it can be called on line #219 too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.