fix: end client before removeAllListeners in stop() to prevent subscribe() hang#173
Closed
kibae wants to merge 8 commits into
Closed
fix: end client before removeAllListeners in stop() to prevent subscribe() hang#173kibae wants to merge 8 commits into
kibae wants to merge 8 commits into
Conversation
…ibe() hang When stop() was called, removeAllListeners() was removing the end/error handlers from the pg client before client.end() was called. This caused the subscribe() promise (which awaits plugin.start()) to never resolve or reject, hanging the caller indefinitely. Fix: call client.end() first, then remove listeners. Fixes #172
|
Wow this was lightning fast! Thx <3 |
…unexpected disconnect Adds _intentionalStop flag to distinguish between: - stop() called explicitly: subscribe() promise resolves cleanly (no throw) - unexpected disconnect: subscribe() promise rejects, error event emitted This prevents the proc() retry pattern from spinning when stop() is called, while preserving error handling for real connection failures.
…be() on stop() Instead of reordering client.end() which caused 'Connection terminated' errors, use a deferred promise that stop() resolves to signal subscribe() to return cleanly. - stop() calls _stopResolve() before closing the connection - subscribe() races plugin.start() against the stop signal - Unexpected disconnects still propagate as errors via the catch block - No breaking changes to existing code patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
Problem
When
stop()was called,removeAllListeners()stripped theend/errorhandlers from the pg client beforeclient.end()was called. This caused thesubscribe()promise to never resolve or reject — hanging the caller indefinitely.Fix
Call
client.end()first, then remove listeners. This ensures the pg query promise insidesubscribe()is properly notified when the connection closes.