Clean up custom console output with utils#712
Merged
epage merged 2 commits intokillercup:masterfrom Jun 28, 2022
Merged
Conversation
epage
reviewed
Jun 22, 2022
Collaborator
epage
left a comment
There was a problem hiding this comment.
Thanks! I hadn't even considered aligning the printing
Contributor
Author
|
Okay! I wasn't originally planning on directly mimicking Cargo's internal implementation of the shell utilities, but seeing the merits of that, I renamed the functions as requested. I also added a Per your request, I also reverted all changes made to cargo add. It turns out the only instance of an uppercase message is inside cargo add, for what it's worth: Lines 582 to 585 in fdb12eb |
Fixes an off-by-one relative to the rest of the project's output formatting.
Contributor
Author
|
Okay! I've cleaned up the git history quite a bit. Should be good to merge. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use utility functions to simplify styling and make the existing styling and indentation more consistent.
A few instances of manual styling remain:
set_version.rsandupgrade.rs(these could use an aesthetic pass too though, since they look out of place).set_version.This also serves as a step towards #682, as these utilities functions are similar in form to Cargo's shell output.