Added a gate delay parameter.#4
Open
prestonj wants to merge 1 commit into
Open
Conversation
This parameter is set for each individual CV output and controls how many ticks the GATE_ON message is delayed by. In particular, this fixes issues when connecting CARBON to the Moog DFAM (CV -> velocity, GATE -> trigger). It seems as though the DFAM is either very intolerant to timing discrepancies between the velocity + trigger inputs, or that the DFAM itself is delayed in recognizing voltage changes to the velocity input. In either case, delaying the CARBON GATE ON message by about 3-4 ticks fixes the problem. This parameter is saved with the song data and thus required an increment to the CARBON version (1.15 now). I've only done basic testing with a simple track using ABCD cv pairing. It would be interesting to see how this holds up in a polyphonic scenario, or even LIVE mode (which I haven't even used yet).
Author
|
This branch will need revising as release branch has incremented the minor version. src/config.h has changed but there is also a reference to the version when loading song data that will need modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parameter is set for each individual CV output and controls how many ticks the GATE_ON message is delayed by. In particular, this fixes issues when connecting CARBON to the Moog DFAM (CV -> velocity, GATE -> trigger). It seems as though the DFAM is either very intolerant to timing discrepancies between the velocity + trigger inputs, or that the DFAM itself is delayed in recognizing voltage changes to the velocity input. In either case, delaying the CARBON GATE ON message by about 3-4 ticks fixes the problem.
This parameter is saved with the song data and thus required an increment to the CARBON version (1.15 now). I've only done basic testing with a simple track using ABCD cv pairing. It would be interesting to see how this holds up in a polyphonic scenario, or even LIVE mode (which I haven't even used yet).