Skip to content

copy and paste steps in step edit mode#6

Open
Klinkenstecker wants to merge 1 commit into
kilpatrickaudio:releasefrom
Klinkenstecker:copy-step
Open

copy and paste steps in step edit mode#6
Klinkenstecker wants to merge 1 commit into
kilpatrickaudio:releasefrom
Klinkenstecker:copy-step

Conversation

@Klinkenstecker
Copy link
Copy Markdown

I use carbon a lot for my guitar pedals, but editing the CCs via step edit mode is cumbersome, as I must enter for each step the CC number(s) again. So I have added a copy & paste feature.
As long as Step Mode is active, the Song Mode button is utilized for this feature (instead of activate the Song Mode). Shift-Song Mode marks the current track and step, and Song Mode will copy the events from this marked track/step to the current track/step. So I must enter only the CC numbers in one step, press Shift-Song Mode, select a new step, copy it with Song Mode and must only edit the values. Of course this can be also used to copy notes.

@kilpatrickaudio
Copy link
Copy Markdown
Owner

This sounds very cool! Now that we have the new bootloader system up and running I plan to make more often / smaller releases and will look to integrate this soon.

@Klinkenstecker
Copy link
Copy Markdown
Author

Good to hear. Currently only the track_events are copied, I will add a commit in the next days that also copies the track_step_params.

@Klinkenstecker
Copy link
Copy Markdown
Author

Here is now the pull request that also copies the track_step_params, and also should supports (i havn't testet this) the SONG_NOTES_PER_SCENE mode (notes can be copied from one scene to another).

@mikeyford
Copy link
Copy Markdown

mikeyford commented Nov 26, 2020

Are there any plans to merge this PR? I was exploring the codebase while considering to implement this very feature and was excited to see it had already been done. I can help test this if needed.

(fwiw, I'd maybe consider utilizing the load / shift-load (save) labeled button for this functionality instead of song mode, to make this a bit more consistent with existing labels and discoverable...just a minor nit though, this looks great in general)

@hires
Copy link
Copy Markdown
Collaborator

hires commented Nov 26, 2020

Hi mikeyford,

I haven't had a chance to review these changes yet. This past year has been crazy busy, but over the holidays I hope to have some time to look at CARBON and make an update incorporating the outstanding PRs if possible. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants