Skip to content

Fix blueprints: dependencyDepth is not defined#108

Merged
kimroen merged 1 commit intokimroen:masterfrom
mriska:master
Jun 5, 2016
Merged

Fix blueprints: dependencyDepth is not defined#108
kimroen merged 1 commit intokimroen:masterfrom
mriska:master

Conversation

@mriska
Copy link
Contributor

@mriska mriska commented May 8, 2016

When using the generators for helpers-test or initializers-test I was getting the following error:

➜  cs-test git:(master) ✗ ember generate initializer-test foo
version: 2.3.0
installing initializer-test
  create tests/unit/initializers/foo-test.coffee
dependencyDepth is not defined (Error in blueprint template: /Users/mriska/work/ember-cli-coffeescript/blueprints/initializer-test/files/tests/unit/initializers/__name__-test.coffee)
ReferenceError: dependencyDepth is not defined (Error in blueprint template: /Users/mriska/work/ember-cli-coffeescript/blueprints/initializer-test/files/tests/unit/initializers/__name__-test.coffee)
  at eval (<anonymous>:8:11)
  at processTemplate (/Users/mriska/work/cs-test/node_modules/ember-cli/lib/models/file-info.js:19:36)
  at /Users/mriska/work/cs-test/node_modules/ember-cli/lib/models/file-info.js:100:20
  at lib$rsvp$$internal$$tryCatch (/Users/mriska/work/cs-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1036:16)
  at lib$rsvp$$internal$$invokeCallback (/Users/mriska/work/cs-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1048:17)
  at lib$rsvp$$internal$$publish (/Users/mriska/work/cs-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1019:11)
  at lib$rsvp$asap$$flush (/Users/mriska/work/cs-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1198:9)
  at _combinedTickCallback (internal/process/next_tick.js:67:7)
  at process._tickCallback (internal/process/next_tick.js:98:9)

The following changes to the blueprint seems to fix that error. dasherizedModulePrefix is what is being used in the standard ember-cli blueprints.

@mriska
Copy link
Contributor Author

mriska commented Jun 3, 2016

@kimroen Have you had a chance to look at this?

@kimroen
Copy link
Owner

kimroen commented Jun 5, 2016

Unfortunately not. Thanks for submitting and following up though!

Taking a look now - starting with trying to figure out where this change came and see if I need to account for older version behavior.

@kimroen
Copy link
Owner

kimroen commented Jun 5, 2016

This was introduced in this PR: ember-cli/ember-cli#5418

This change only works for ember-cli 2.3.0 and up. It will break for people using older versions, but I'm leaning towards saying that that's okay.

This change was also introduced for instance-initializer-test, which is yet to be added to this project.

@kimroen kimroen merged commit da563da into kimroen:master Jun 5, 2016
@kimroen
Copy link
Owner

kimroen commented Jun 5, 2016

Released as 1.14.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants