Fix blueprints: dependencyDepth is not defined#108
Merged
kimroen merged 1 commit intokimroen:masterfrom Jun 5, 2016
Merged
Conversation
Contributor
Author
|
@kimroen Have you had a chance to look at this? |
Owner
|
Unfortunately not. Thanks for submitting and following up though! Taking a look now - starting with trying to figure out where this change came and see if I need to account for older version behavior. |
Owner
|
This was introduced in this PR: ember-cli/ember-cli#5418 This change only works for ember-cli 2.3.0 and up. It will break for people using older versions, but I'm leaning towards saying that that's okay. This change was also introduced for |
Owner
|
Released as 1.14.0. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the generators for
helpers-testorinitializers-testI was getting the following error:The following changes to the blueprint seems to fix that error.
dasherizedModulePrefixis what is being used in the standardember-cliblueprints.