Skip to content

need to exclude ourselves when looking up blueprints#115

Merged
kimroen merged 3 commits intokimroen:masterfrom
kbullaughey:smarter-ancestral-blueprint-lookup
Aug 17, 2016
Merged

need to exclude ourselves when looking up blueprints#115
kimroen merged 3 commits intokimroen:masterfrom
kbullaughey:smarter-ancestral-blueprint-lookup

Conversation

@kbullaughey
Copy link
Contributor

This fixes #114.

As I understand things, the coffeescript blueprints relied on finding the non-coffeescript blueprint using lookupBlueprint. Now that the blueprints have moved into the ember-cli-legacy-blueprints addon, this lookup wasn't working. I found I needed to exclude the coffeescript blueprints when the legacy blueprints were searched for. I accomplished this using a new method, ancestralBlueprint that I stashed in lib/utilities/ancestral-blueprint.

Not sure this is the optimal strategy, but it seems to work, and I was able to generate all the blueprints that rely on lookupBlueprint.

@mazondo
Copy link

mazondo commented Aug 9, 2016

Can we get this merged in, or is there a better solution coming?

@kimroen
Copy link
Owner

kimroen commented Aug 17, 2016

I'm very sorry that I've left this and other projects hanging. I'll merge this in now, then try out some things manually, and release a new version with this and some other fixes (hopefully soon, but I can't promise anything).

I'll need to figure out if this breaks on older versions of ember-cli or not, because if it does then I need to bump the major version number, and I kind of want to implement tests before I do so.

Thank you very much for looking in to this.

@kimroen kimroen merged commit ebb4abd into kimroen:master Aug 17, 2016
@deverin
Copy link

deverin commented Aug 17, 2016

This fixes #116

@kimroen
Copy link
Owner

kimroen commented Oct 3, 2016

This has now been released as v1.15.0, with some tweaks (#118) to make it work on older versions of Ember CLI as well.

Thank you again for your help, and for being patient with me. 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blueprints don't work with Ember 2.6

4 participants