need to exclude ourselves when looking up blueprints#115
Merged
kimroen merged 3 commits intokimroen:masterfrom Aug 17, 2016
Merged
need to exclude ourselves when looking up blueprints#115kimroen merged 3 commits intokimroen:masterfrom
kimroen merged 3 commits intokimroen:masterfrom
Conversation
|
Can we get this merged in, or is there a better solution coming? |
Owner
|
I'm very sorry that I've left this and other projects hanging. I'll merge this in now, then try out some things manually, and release a new version with this and some other fixes (hopefully soon, but I can't promise anything). I'll need to figure out if this breaks on older versions of ember-cli or not, because if it does then I need to bump the major version number, and I kind of want to implement tests before I do so. Thank you very much for looking in to this. |
|
This fixes #116 |
Owner
|
This has now been released as Thank you again for your help, and for being patient with me. 🎈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #114.
As I understand things, the coffeescript blueprints relied on finding the non-coffeescript blueprint using
lookupBlueprint. Now that the blueprints have moved into theember-cli-legacy-blueprintsaddon, this lookup wasn't working. I found I needed to exclude the coffeescript blueprints when the legacy blueprints were searched for. I accomplished this using a new method,ancestralBlueprintthat I stashed inlib/utilities/ancestral-blueprint.Not sure this is the optimal strategy, but it seems to work, and I was able to generate all the blueprints that rely on
lookupBlueprint.