update acceptance test generator#51
Merged
kimroen merged 3 commits intokimroen:masterfrom Feb 4, 2015
Merged
Conversation
Newer versions of QUnit use the return value of `setup` and `teardown` to wait for promises if the return value has a `.then` function. There are a few problems with this: 1) Ember.Application.then is deprecated 2) The promise never resolves if you are calling `visit`/etc in the test block. The code to make the promise resolved can't run before setup is done (`test` waits for `setup`). This fixes `ember generate acceptance-test` hanging by default.
Owner
|
Thanks! You can choose to not return anything by ending the function with just |
Contributor
|
Thanks for this - it was causing my integration tests to hang. Glad to see a fix so fast. |
Owner
|
Thanks again! 👍 |
kimroen
added a commit
that referenced
this pull request
Feb 4, 2015
update acceptance test generator
Owner
|
Published as version 0.8.1, with some other small bugfixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of QUnit use the return value of
setupandteardownto wait for promises if the return value has a.thenfunction. Coffeescript has implicit return so it returns the Application instance by default. There are a few problems with this:visit/etc in the test block. The code to make the promise resolved can't run before setup is done (testwaits forsetup).This fixes
ember generate acceptance-testhanging by default.