Skip to content

Update test blueprints to reflect qunit 2.0 compatibility#54

Merged
kimroen merged 2 commits intokimroen:masterfrom
taddeimania:qunit-2-compat
Feb 11, 2015
Merged

Update test blueprints to reflect qunit 2.0 compatibility#54
kimroen merged 2 commits intokimroen:masterfrom
taddeimania:qunit-2-compat

Conversation

@taddeimania
Copy link
Contributor

This commit should keep the blueprints up to date with recent changes in ember-cli meant to coincide with new qunit deprecations.

See commit here: ember-cli/ember-cli@c35e358

This can probably wait until the next ember-cli version is released containing the new test blueprints.

@kimroen
Copy link
Owner

kimroen commented Feb 4, 2015

Thank you very much for doing this. I will hold off until ember-cli is updated, like you suggest.

👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been renamed to render() (ember-cli/ember-cli@b13bde0)

@taddeimania
Copy link
Contributor Author

Updated commit to replace append to render.

@taddeimania
Copy link
Contributor Author

rebased your master branch into this PR today to make it easier to merge.

@taddeimania
Copy link
Contributor Author

Looks like CLI can't make up it's mind - i'll update the PR tonight to reflect this pending PR for cli.

rwjblue/ember-cli@3d233a8

@kimroen
Copy link
Owner

kimroen commented Feb 9, 2015

Awesome :) Hopefully there's a new version of ember-cli soon.

@taddeimania
Copy link
Contributor Author

This commit: https://github.com/taddeimania/ember-cli-coffeescript/commit/fd33db2bc151a0896f8e27b744aaa7aa8a82e87c removes QUnit globals from test blueprints to coincide with upcoming QUnit 0.2 compat changes.

See: rwjblue/ember-cli@3d233a8

@kimroen kimroen mentioned this pull request Feb 11, 2015
@taddeimania
Copy link
Contributor Author

The new version of ember-cli was cut so this PR is relevant now! Go ahead and merge.

kimroen added a commit that referenced this pull request Feb 11, 2015
Update test blueprints to reflect qunit 2.0 compatibility
@kimroen kimroen merged commit 55f0691 into kimroen:master Feb 11, 2015
@kimroen
Copy link
Owner

kimroen commented Feb 11, 2015

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants