Fix filtering to use coffeescript extensions#64
Merged
kimroen merged 2 commits intokimroen:masterfrom Mar 10, 2015
Merged
Conversation
Since there are no options to configure the `ext` property at creation, might as well assign via prototype (as a bonus, allows other plugins to inspect the extensions without instantiation, allowing them to delegate the Coffeescript extensions to this single, authoritative source).
Owner
|
Hi! This seems reasonable, and thanks for catching it. I'll have to test it a little bit to make sure, but I'll get it merged and released with other improvements scheduled for the release of ember-cli 0.2 in hopefully not too long. |
Contributor
Author
|
ping @rwjblue at his request |
kimroen
added a commit
that referenced
this pull request
Mar 10, 2015
Fix filtering to use coffeescript extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might be totally off base here, so feel free to let me know.
It seems that this extension should be the source extension, not the target extension. It is ultimately used by
extensionsForTypeinside ember-cli to build a regex pattern of files to search for, and when it's set tojs, the regex completely misses the Coffeescript source files, and the files are never preprocessed / included in the build output.This
extensionsForTypecodepath doesn't seem to execute for the/appfolder, but does on theaddonfolder. This previously didn't matter, since pre 0.2.0-beta.1, nested addon preprocessors weren't supported. But now that they are, it seems this is required.I'm still wrapping my head around the nested addon stuff, so let me know if I missed something obvious on this one.