Conversation
Owner
Author
|
This seems to be a bit in flux in ember-cli, so I'll hold off on this change for now. |
Owner
Author
kimroen
force-pushed
the
component-changes
branch
2 times, most recently
from
27e83a6 to
74d21f3
Compare
|
👍 Looking forward! Many thanks for your great work on this architecture! |
Owner
Author
|
I ran in to an issue overriding some things, which I reported here: ember-cli/ember-cli#4001 |
kimroen
changed the title
kimroen
added a commit
that referenced
this pull request
May 3, 2015
Redo components to match ember-cli
Owner
Author
|
@artsyca Released 0.11.0 with this and some other things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the changes to components as implemented here and elsewhere: ember-cli/ember-cli#3356
This is a fairly straight-forward change which mirrors the ember-cli one in most ways.
addonfolder, and a javascript-file is generated inapp. This is the recommended way forward.To make this happen, I'm overriding and changing some strings in
localsin the base blueprint, but the superclass takes care of the logic of picking which path to take. Because we want javascript in theapp-folder, letting the built-incomponent-addonblueprint do its thing works out here.