Fix for issue with recent versions of ember-cli (Cannot read property 'dummy' of undefined)#88
Merged
kimroen merged 1 commit intokimroen:masterfrom Aug 5, 2015
perlun:patch-1
Merged
Fix for issue with recent versions of ember-cli (Cannot read property 'dummy' of undefined)#88kimroen merged 1 commit intokimroen:masterfrom perlun:patch-1
kimroen merged 1 commit intokimroen:masterfrom
perlun:patch-1
Conversation
With the most recent versions of `ember-cli`, you get exceptions like this when doing `ember destroy route` or `ember generate route`. ``` $ ember destroy route foo version: 1.13.6 Could not find watchman, falling back to NodeWatcher for file system events. Visit http://www.ember-cli.com/user-guide/#watchman for more info. uninstalling route remove app/routes/foo.coffee remove app/templates/foo.hbs Cannot read property 'dummy' of undefined TypeError: Cannot read property 'dummy' of undefined at Class.module.exports.shouldTouchRouter (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli/blueprints/route/index.js:66:28) at Class.module.exports.shouldTouchRouter (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli-coffeescript/blueprints/route/index.js:31:42) at Class.module.exports.shouldTouchRouter (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli-coffeescript/blueprints/route/index.js:31:42) at Class.module.exports.afterUninstall (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli-coffeescript/blueprints/route/index.js:52:14) at lib$rsvp$$internal$$tryCatch (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:493:16) at lib$rsvp$$internal$$invokeCallback (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:505:17) at lib$rsvp$$internal$$publish (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:476:11) at lib$rsvp$asap$$flush (/Users/plundberg/tmp/ember-cli-test/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1198:9) at process._tickCallback (node.js:355:11) ``` The problem was that `shouldTouchRouter` now assumes that it will get the `options` object passed in as a parameter. This commit fixes this. (thanks to @mriska for helping me out to nail this one down)
|
Big 👍 was struggling with this yesterday and thought it was my local setup. Good to walk in today and see a well-written explanation and PR! |
|
(and just FWIW I applied this fix locally and verified both |
Owner
|
Thank you very much for looking in to and finding the time to work this one out! |
kimroen
added a commit
that referenced
this pull request
Aug 5, 2015
Fix for issue with recent versions of ember-cli (Cannot read property 'dummy' of undefined)
Owner
|
Thanks again - this has now been released with version 1.13.0, along with updates to all the blueprints. Sorry about the wait. |
Contributor
Author
|
Well, I kind of had to look into it to avoid errors when running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the most recent versions of
ember-cli, you get exceptions like this when doingember destroy routeorember generate route.The problem was that
shouldTouchRouternow assumes that it will get theoptionsobject passed in as a parameter. This commit fixes this. (thanks to @mriska for helping me out to nail this one down)