fix(js-utils): remove webpackIgnore from ExpoSecureStore dynamic import#202
Open
shafaladhikari wants to merge 2 commits into
Open
fix(js-utils): remove webpackIgnore from ExpoSecureStore dynamic import#202shafaladhikari wants to merge 2 commits into
shafaladhikari wants to merge 2 commits into
Conversation
Contributor
WalkthroughTwo files have been updated to remove webpack-specific Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Will take a look shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain your changes
This PR removes the
webpackIgnore: truehint from the dynamic importused to load the Expo secure store implementation.
Fixes #212
Problem
The current implementation:
prevents bundlers from resolving the module. While this avoids some
Webpack resolution issues in web environments, it causes problems for
Expo / React Native environments because Metro cannot correctly resolve
and bundle the module.
As a result, the Expo SDK cannot load the secure store implementation at
runtime when upgrading
@kinde/js-utils.Solution
Remove the
webpackIgnorehint so bundlers can resolve the modulenormally:
Validation
Tested with:
This change only removes the webpack hint and does not alter runtime
logic.
Checklist
guidelines.