This repository was archived by the owner on May 14, 2021. It is now read-only.
Merged
Conversation
added 2 commits
August 15, 2019 11:29
katzio
reviewed
Aug 21, 2019
| pass | ||
| else: | ||
| current_loop_txs.append(raw_tx) | ||
| cursor = transaction['paging_token'] |
There was a problem hiding this comment.
I don't see a use for cursor, guess it's a leftover
Contributor
Author
There was a problem hiding this comment.
It is used for the next request, line 220
katzio
reviewed
Aug 21, 2019
| simple_tx = SimplifiedTransaction(raw_tx) | ||
| current_loop_txs.append(simple_tx) | ||
| except KinErrors.CantSimplifyError: | ||
| pass |
There was a problem hiding this comment.
hm, why not append it as is (like you did in the else section)?
and log the error
Contributor
Author
There was a problem hiding this comment.
That's just the way the method works, if you only want simple txs it skips everything else
yosriz
approved these changes
Aug 25, 2019
|
@Ronserruya can you add tests for the fix? i.e a scenario with paging? |
Contributor
Author
There is already a test for paging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed paging with txs history, before the fix the "get_tx_history" method returned None if it had to use paging.
Also changed the implementation from recursion to loop