This repository was archived by the owner on May 14, 2021. It is now read-only.
optimize for zero balance + caching layer#9
Merged
doodyparizada merged 14 commits intolior/ecosystemfrom May 29, 2019
Merged
Conversation
Ronserruya
reviewed
May 27, 2019
src/app.py
Outdated
| """migrate an account with zero balance.""" | ||
| if kin3_account_data is None: | ||
| try: | ||
| main_account.create_account(account_address, starting_balance=0, fee=0) |
Contributor
There was a problem hiding this comment.
We always create the proxy account as well, as proof that the migration passed. Although it is fine if it has 0 balance.
Author
There was a problem hiding this comment.
@Ronserruya Does anyone other than the migration service use the proxy accounts?
Ronserruya
approved these changes
May 27, 2019
doodyparizada
force-pushed
the
doody/optimize_zero_balance
branch
from
c1efbf1 to
a9a58b9
Compare
doodyparizada
changed the title
doodyparizada
force-pushed
the
doody/optimize_zero_balance
branch
from
ae6f2ca to
f6811fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.