Fix encoder runtime failures and CoS table selection flow#31
Merged
Conversation
Agent-Logs-Url: https://github.com/kingkillery/Spreadsheet_LLM_Encoder/sessions/aae2984d-792f-44b3-ae90-25e2814a99fd Co-authored-by: kingkillery <200727508+kingkillery@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kingkillery/Spreadsheet_LLM_Encoder/sessions/aae2984d-792f-44b3-ae90-25e2814a99fd Co-authored-by: kingkillery <200727508+kingkillery@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kingkillery/Spreadsheet_LLM_Encoder/sessions/aae2984d-792f-44b3-ae90-25e2814a99fd Co-authored-by: kingkillery <200727508+kingkillery@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kingkillery/Spreadsheet_LLM_Encoder/sessions/aae2984d-792f-44b3-ae90-25e2814a99fd Co-authored-by: kingkillery <200727508+kingkillery@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kingkillery
April 29, 2026 06:07
View session
Owner
|
@copilot can we close any of the issues? |
Contributor
Author
Yes — #28 can be closed by this PR. The encoder crash from the missing |
Owner
Copilot stopped work on behalf of
kingkillery due to an error
April 29, 2026 06:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder path described in the README had two critical runtime breaks: the main encoding pipeline called a missing aggregation function, and the Chain-of-Spreadsheet flow conflated table ranges with sheet names. This change restores the broken execution paths and tightens a couple of adjacent correctness issues surfaced by the same failure analysis.
Restore format-region aggregation in the encoder
aggregate_regions_dfs()and wire it into the existing encoding flow where it was already being called.spreadsheet_llm_encode()can complete instead of failing withNameError.Fix CoS sheet/range handling
identify_table()responsible for returning the detected table range, whilefind_relevant_sheet()resolves the sheet key used to read encoded data.Correct boundary candidate filtering
Tighten spreadsheet dataset loading
.xlsx/.jsonpairs that do not contain table annotations when building the table-detection dataset.