🛡️ Sentinel: [Security Enhancement] Add input length limits to prevent DoS

[kingkillery]

🚨 Severity: MEDIUM
💡 Vulnerability: Missing input length limits on the image_size parameter in commonforms/inference.py. If a malicious or malformed input provided an extremely large image_size (e.g., billions), it could lead to memory exhaustion and a Denial of Service (DoS) when passed to the YOLO model.
🎯 Impact: An attacker could crash the application or exhaust system memory by providing an extremely large image size parameter.
🔧 Fix: Added a maximum boundary IMAGE_SIZE_MAX: int = 4096 in commonforms/config.py. Updated _validate_inputs in commonforms/inference.py to enforce that image_size is between the minimum and maximum boundaries. Updated InvalidImageSizeError in commonforms/exceptions.py to correctly report the boundary limits. Also fixed a pre-existing minor linting issue (unnecessary f-string) in dataset/split_dataset.py.
✅ Verification: Ran uv run pytest tests/ to verify tests pass and uv run ruff check commonforms/ tests/ dataset/ to verify linting.

---

PR created automatically by Jules for task 541704117853209818 started by @kingkillery

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Rate limit exceeded

@kingkillery has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 9 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 9 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 94e09d6f-4c13-49a7-8367-e22585b5066d

📥 Commits

Reviewing files that changed from the base of the PR and between e00f2d1 and 1643ebb.

📒 Files selected for processing (4)

• commonforms/config.py
• commonforms/exceptions.py
• commonforms/inference.py
• dataset/split_dataset.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-dos-image-size-541704117853209818

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}