Allow consumers to check if device is attached #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Good idea, thanks! I can make a release including this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the ability to check if a FIDO2 device is attached.
Whilst adding PIN-less support to the Xcodes app, it had become evident that in order to support a nice UX around the PIN-less assertation we need a way to know if a device is present.
It is possible to kind of achieve this with the current API that the library has but it does put the onus of dealing with errors on the consumer of the API. This change should hopefully make that much simpler for upstream projects.
I've also added a little UI into the dev app to check this functionality.
