Add Prometheus metrics and monitoring for Redis#11
Open
Conversation
- Add prom-client dependency for metrics - Create /metrics endpoint exposing Prometheus metrics - Track Redis connection status (database_redis_connection_status) - Track Redis operation success/failure counts by operation type - Update RedisCache to report connection events and operation metrics - Add comprehensive monitoring documentation Metrics exposed: - database_redis_connection_status: 1=connected, 0=disconnected - database_redis_operation_success_total: successful operations by type - database_redis_operation_failures_total: failed operations by type Note: This PR is independent and can be deployed alongside PR #10 for graceful Redis failure handling, or standalone for monitoring only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds comprehensive Prometheus metrics and monitoring for Redis connection status and operation health.
Changes Made
Application Code
Added metrics module -
src/metrics.ts:Updated RedisCache -
src/RedisCache.ts:Added /metrics endpoint -
src/index.ts:/metricsendpointAdded prom-client dependency -
package.jsonDocumentation -
REDIS_MONITORING.md:Kubernetes/Helm Changes (in separate kipr-yamls repo)
Already pushed to kipr-yamls main branch:
Alerts Configured
Grafana Dashboard
A dashboard JSON is available (not included in this PR) with:
Testing
This PR is UNTESTED and should be validated in staging:
Compatibility