wrap dataloader and model init in try block for MMSplice#91
Open
ramprasadn wants to merge 1 commit intokircherlab:masterfrom
Open
wrap dataloader and model init in try block for MMSplice#91ramprasadn wants to merge 1 commit intokircherlab:masterfrom
ramprasadn wants to merge 1 commit intokircherlab:masterfrom
Conversation
Extends the ValueError catch to include SplicingVCFDataloader and MMSplice() initialization, not just the prediction step, to handle cases where no variants fall in splice regions.
Collaborator
|
@ramprasadn Thank you! Can you give me an example variant to check? |
Author
|
Sure! Here is the file that caused MMsplice to crash. |
Collaborator
|
@ramprasadn I looked at your data. CADD does not support mitochondrial variants (chrM), and all of your variants are on chrM. So you won’t get any CADD scores from them anyway. It’s absolutely fine if the pipeline fails with this input. On our web services, we have a filter script upstream that removes such cases before they are processed by the CADD scripts. Do you have any other variants on chr1–22 or chrX where you see the same issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only the
predict_table_fastcall was inside thetry/except ValueErrorblock. IfSplicingVCFDataloaderorMMSplice()raised aValueError, which can happen when no input variants fall within splice regions, the exception was unhandled and the script would crash.This fix extends the
tryblock to include the dataloader and model initialization, ensuring the same graceful fallback to an emptypred_dictapplies regardless of where theValueErrororiginates.