PoC for linked cards with semantic link around the title #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client pointed out that the current card implementation doesn't show the href target in the browser status bar.
Here's a proof of concept trying to solve that by moving the card
atag to be a normal semantic link around the card title, instead of an empty link at the start of the card.If this is promising, we need to check carefully that we aren't regressing anything in terms of accessibility, add support for it in the other summary components, and update docs and storybook.
Unfortunately it's breaking because if someone used a custom summary component, it has to be updated or else the card won't be linked.