Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 57.62% 57.77% +0.15%
==========================================
Files 113 113
Lines 6994 6960 -34
==========================================
- Hits 4030 4021 -9
+ Misses 2964 2939 -25
|
kiudee
previously approved these changes
Aug 3, 2020
Owner
kiudee
left a comment
kiudee
left a comment
There was a problem hiding this comment.
I like the change, since it is much more explicit. Also the threshold_instances was hardcoded to 1e10, which is not good.
The threshold was not configurable and the behavior somewhat unexpected. Its better to let the library user decide themselves.
If the library user wants to reduce the dataset, they can just do so themselves. The current behavior is unexpected, even more so since the threshold is not configurable.
timokau
force-pushed
the
remove-threshold-instances
branch
from
c7e755e to
7fcde4b
Compare
Collaborator
Author
|
Skimmed the changes again before merging and noticed a small typo (wether instead of whether). Please re-approve. |
kiudee
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The next part in the #116 saga: I'm starting to remove instance attributes that are not parameters. The first one is
instance_thresholds, which doesn't look like a useful feature to me. There is two distinct use cases, one simply reduces the dataset size and the other picks a simpler model. I have removed the first and replaced the second by an explicit parameter.Motivation and Context
Less surprising behavior and #116.
How Has This Been Tested?
Test suite and lints.
Does this close/impact existing issues?
Types of changes
Checklist: