decode function potential bug

[ali-naq-v]

Hi guys, just wanted to run this by here. Would the body of the second if statement ever be hit? Doesn't seem like it would. Is this a bug?

            if isinstance(f, Group):
                assert cursor.val >= header.value['blockLength']
                if cursor.val < header.value['blockLength']:
                    format_str_parts.append(str(header.value['blockLength'] - cursor.val) + 'x')

Link to line of the code

[baryluk]

In 0.2.8 it was:

         if isinstance(f, Group):
                assert cursor.val <= header.value['blockLength']
                if cursor.val < header.value['blockLength']:
                    format_str_parts.append(str(header.value['blockLength'] - cursor.val) + 'x')

[baryluk]

There is open PR about this https://github.com/kizzx2/sbe-python/pull/5/files

[ali-naq-v]

looks good in the PR #5
closing